Re: [Xen-devel] [PATCH] pygrub: parse xen module option in grub

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

On Fri, Feb 20, 2009 at 10:40:14AM +0800, Wei Kong wrote:

> Add function for GrubConf to parse xen module option in grub.

Why?

> Pygrub should pass args as domUloader did.

domUloader was never in the tree.

> -            sxp += "(args \"%s\")" % chosencfg["args"]
> +            sxp += "(args \"%s %s\")" % (chosencfg["args"], incfg["args"])

Are you trying to let the user add arguments to the ones specified in
grub? Why?

The patch is wrong anyway, you can't just add on the incoming args for
Solaris at least. At the very least you need to add the args only when
run_grub() is called.

john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel