Re: [Xen-devel] [PATCH 1 of 3] fix S3 suspend error

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 23/02/2009 07:27, "Guanqun Lu" <guanqun.lu@xxxxxxxxx> wrote:

> fix S3 suspend error.
> 
> invoke ioapic_pm_state_alloc() eariler,
> thus avoiding check_lock() BUG_ON() in spin_lock().
> 
> Signed-off-by: Guanqun Lu <guanqun.lu@xxxxxxxxx>

This one I think is a good idea anyway. The other two -- I wonder why we do
device suspend/resume with IRQs disabled? As far as I can tell Linux does
not do that. So would it be cleaner to move the device suspend/resume hooks
outside the IRQs-disabled region?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel