RE: [Xen-devel] [PATCH] only set scheduler timer for non-idle CPU

["Yu, Ke" <ke.yu@xxxxxxxxx>]

>-----Original Message-----
>From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
>Sent: Thursday, April 02, 2009 9:19 PM
>To: Keir Fraser; Thomas Pfeuffer; Yu, Ke; xen-devel@xxxxxxxxxxxxxxxxxxx
>Subject: Re: [Xen-devel] [PATCH] only set scheduler timer for non-idle CPU
>
>On 02/04/2009 14:06, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:
>
>>> I think your patch is not good in case sedf-scheduler is used. If idle VCPU
>>> is the current "running" VCPU, the scheduler timer is set to the next 
>>> "period
>>> begin" of the first VCPU in the wait queue.
>>> Your patch prevents sedf from taking the VCPUs waiting for their next period
>>> into the runnable queue again.

I did not look into the much detail of the sedf-scheduler when making this 
patch. thanks for pointing it out, Thomas.

>>
>> It¹s probably cleaner always to respect the specific scheduler¹s scheduling
>> quantum in schedule.c, but then have sched_credit.c return a very large
>> quantum (large as possible) for the idle VCPU.
>
>I checked in something to this effect as c/s 19500.
>
> -- Keir
>

This change looks good to me. Thanks.

Best Regards
Ke

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel