[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] do_domctl and EAGAIN


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
  • Date: Tue, 07 Apr 2009 09:04:58 +0200
  • Delivery-date: Tue, 07 Apr 2009 00:05:30 -0700
  • Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:Subject:X-Enigmail-Version: Content-Type:Content-Transfer-Encoding; b=AfsZQuA8+xjTzE3RB4rFxbXFylkplBS+obwq9u69EVOZns31CI+Xx2Z4 HhxDP5DLWkzWrgzj6+iaaTOdiJfhspirQB9yBcfGJX01OU5DMfjJhMrN3 daGOQiUQof+kEymkh9VC4vjpKlzW6WPEDwnPmDbDzQ0637Qc+TE5fy4gO tebNNNENuCrX8fFgJKZrk1Qm+LWfxzhIz5yU7zm+ZOjbF4AYPlMU2kJDh bvl0ZO4z3Jhj3qyvKKusmcrnqgbZR;
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Hi,

certain domctl hypercalls (and possibly others as well) might fail with errno
EAGAIN. This case seems to be tested only in very few places, e.g. in
xc_domain_destroy.

Is there any reason why this case isn't handled in do_domctl?
Shouldn't EINTR be handled as well?

The other solution would be to have two versions of do_domctl, one of them
looping in case of EAGAIN or EINTR.

I suspect this lack of errno-testing could lead to very sporadic failures...


Juergen

-- 
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 636 47950
Fujitsu Technolgy Solutions               e-mail: juergen.gross@xxxxxxxxxxxxxx
Otto-Hahn-Ring 6                        Internet: ts.fujitsu.com
D-81739 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.