[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel][PATCH]ioemu:fix up error when using qemu-img-xen to create img



Ian, saw your back, how do you think of this patch?
Thanks!
-Xin

>-----Original Message-----
>From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Li, Xin
>Sent: Monday, April 27, 2009 11:13 AM
>To: Zhang, Yang; Ian Jackson
>Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
>Subject: RE: [Xen-devel][PATCH]ioemu:fix up error when using qemu-img-xen to
>create img
>
>Hi Ian,
>Any comments on this patch? it's a block issue to our QA test.
>Thanks!
>-Xin
>
>>-----Original Message-----
>>From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Zhang, Yang
>>Sent: Tuesday, April 21, 2009 9:24 AM
>>To: Ian Jackson
>>Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
>>Subject: [Xen-devel][PATCH]ioemu:fix up error when using qemu-img-xen to
>>create img
>>
>>If find_protocol() can not find the the drv. The caller should give
>>a default value.
>>
>>Signed-off-by: Yang Zhang <yang.zhang@xxxxxxxxx>
>>
>>diff --git a/block.c b/block.c
>>index 8a0e8b2..3e84707 100644
>>--- a/block.c
>>+++ b/block.c
>>@@ -306,6 +306,8 @@ static BlockDriver *find_image_format(const char
>>*filename)
>>     /* no need to test disk image format if the filename told us */
>>     if (drv != NULL)
>>         return drv;
>>+    else
>>+        drv = &bdrv_raw;
>>
>>     ret = bdrv_file_open(&bs, filename, BDRV_O_RDONLY);
>>     if (ret < 0)
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.