RE: [Xen-devel][PATCH]ioemu:fix up error when using qemu-img-xen to create img

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Li, Xin writes ("RE: [Xen-devel][PATCH]ioemu:fix up error when using 
qemu-img-xen to create img"):
> Ian, saw [you're] back, how do you think of this patch?

I replied to this yesterday.  Did you see my mail ?  Here it is again:

   > >+    else
   > >+        drv = &bdrv_raw;

   This appears to reintroduce the image format vulnerability.  Are you
   sure it's right ?

   The effect of your patch seems to be in this case:
     * the filename does not refer to a block device
     * the format is not specified in the filename
     * the actual contents of the image is not autodetected as any
       image format (eg, qcow or qcow2)
   In that case, without your patch, the open fails.  With your patch,
   the file is opened with bdrv_raw.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel