Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for build/install system

[Christoph Egger <Christoph.Egger@xxxxxxx>]

On Tuesday 05 May 2009 16:28:23 Ian Jackson wrote:
> Christoph Egger writes ("Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for 
build/install system"):
> > On Tuesday 05 May 2009 16:00:12 Ian Jackson wrote:
> > > Could you please do this in xen-setup-* instead, rather than in
> > > xen-unstable's Makefiles ?  That (a) avoids coupling between the two
> > > repositories and (b) will mean that xen-setup will do the right thing
> > > when run by hand.
> >
> > I tried, but it doesn't work. It has to be set _before_ xen-setup* is
> > called for the same reason XEN_ROOT is set in xen-unstable's Makefiles.
>
> I don't understand, I'm afraid.
>
> XEN_ROOT needs to be handled the way it is because it's (a) available
> only as a make variable in the xen-unstable makefiles and (b) is a
> relative pathname so needs to be massaged for use by a sub-component.
> If you run xen-setup it guesses a value for XEN_ROOT which is right
> for at least one common case.

PREFIX is defined by xen build system as a make variable. xen's build system
runs some shell code to pass XEN_ROOT as a shell variable to xen-setup.
My patch adds some shell code to pass PREFIX as a shell variable to xen-setup, 
too.

xen-setup can guess XEN_ROOT due to the directory structure
relative to xen's toplevel source directory. But how should xen-setup guess an 
install directory ?

> PREFIX could be set in the environment perfectly well and doesn't need
> any massaging.  You could just have xen-setup invent a default PREFIX
> if none was found in its environment.

No, this would end up in having different prefixes on NetBSD at least.
xen tools go to /usr/pkg and ioemu goes to /usr/local - great!

If you don't know a way how to make xen-setup to read the PREFIX make variable
from xen's build system, then my patch is the only way to go.

Christoph

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel