[Xen-devel] RE: [PATCH][ioemu] fix PCI bar mapping

["Cui, Dexuan" <dexuan.cui@xxxxxxxxx>]

Ian Jackson wrote:
> Yuji Shimada writes ("Re: [PATCH][ioemu] fix PCI bar mapping"):
>> pt_pci_read_config should not be used to read configuration
>> registers. pt_pci_read_config emulates access to read the registers
>> from guest software. Many functions which are not relevant are
>> executed in pt_pci_read_config. So side effects may occur. Instead,
>> you can use pc_read_word of libpci just to read configuration
>> registers. 
> 
> Should we be reverting Cui's patch and fix the problem some other
> way ?
I have posted a new patch according to Yuji's comment.

> 
>> Or, there is another approach. It is that you remove emu_mask from
>> writable_mask in pt_cmd_reg_write. Then you can get the proper value
>> from reg_entry->data.
Please help to review my newly-posted patch for this approach.

> 
> It would be nice to get this sorted for the 3.4 release, which is
> imminent ...
> 
> Ian.


Thanks,
-- Dexuan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel