RE: [Xen-devel] [PATCH] xend: fix the pci BDF format string

["Cui, Dexuan" <dexuan.cui@xxxxxxxxx>]

Sorry, I should have used a better description. Now the patch has been checked 
in with the description...
Anyway, we can use 'hg annotate tools/python/xen/xm/main.py" to locate which 
c/s changed that line easily.

Thanks,
-- Dexuan

-----Original Message-----
From: Simon Horman [mailto:horms@xxxxxxxxxxxx] 
Sent: 2009年5月8日 8:55
To: Cui, Dexuan
Cc: Keir Fraser; xen-devel@xxxxxxxxxxxxxxxxxxx; Yosuke Iwamatsu
Subject: Re: [Xen-devel] [PATCH] xend: fix the pci BDF format string

On Thu, May 07, 2009 at 10:55:40AM +0800, Cui, Dexuan wrote:
> Fix the typo introduced by changeset 19446: 2ef77b4bdf58.

Hi,

I can confirm that this patch fixes the problem, but would
it be possible to have a more descriptive changelog to avoid
having to look up what it was that 19446:2ef77b4bdf58 did?

Perhaps:

xend: Fix the PCI BDF format string used in the output of xm 
pci-list-assignable-devices

This fixes a typo introduced by changeset 19446: 2ef77b4bdf58

> Signed-off-by: Dexuan Cui <dexuan.cui@xxxxxxxxx>
> 
> diff -r fb3e1e84d8f4 tools/python/xen/xm/main.py
> --- a/tools/python/xen/xm/main.py   Wed May 06 12:40:51 2009 +0100
> +++ b/tools/python/xen/xm/main.py   Thu May 07 10:45:47 2009 +0800
> @@ -2197,7 +2197,7 @@ def xm_pci_list_assignable_devices(args)
> 
>      devs =  server.xend.node.pciinfo()
> 
> -    fmt_str = "%(domain)04x:%(bus)02x:%(slot)02x:%(func)01x"
> +    fmt_str = "%(domain)04x:%(bus)02x:%(slot)02x.%(func)01x"
>      for x in devs:
>          pci = parse_pci_info(x)
>          print fmt_str % pci

-- 
Simon Horman
  VA Linux Systems Japan K.K. Satellite Lab in Sydney, Australia
  H: www.vergenet.net/~horms/            W: www.valinux.co.jp/en


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel