Re: [Xen-devel] Re: [PATCH] Fix xm pci-list for inactivemanageddomains

[Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>]

Thu, 14 May 2009 15:42:14 +1000, Simon Horman wrote:

>On Thu, May 14, 2009 at 02:23:20PM +0900, Masaki Kanno wrote:
>> Thu, 14 May 2009 14:59:30 +1000, Simon Horman wrote:
>> >
>> >Hi Kanno-san,
>> >
>> >Ok, understood.
>> >
>> >Have you checked your patch against the case where the vslot is not
>> >specified?  I wonder if you might need a little bit of extra logic for 
>> >that
>> >case.
>> 
>> Hi Simon,
>> 
>> I have tried it.  The default virtual slot number (0x20) is shown.
>> Should not virtual slot numbers be shown in the case?
>
>Hi Kanno-san,
>
>I don't think that it is good to expect that the user will know
>that 0x20 means unasigned. Furthermore, it might be nice to
>be able to change that magic value in the future. I suggest either:
>
>1) Not showing the vSlot in this case or;
>2) Showing something like the string "unassigned"

Hi Simon,

Thanks for your suggestion.
I will choose 2) for the following case.

 e.g.  pci = [ '01:00.0@6','01:00.1' ]

Best regards,
 Kan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel