[Xen-devel] Re: [PATCH 06/10] x86/PCI: Enable scanning of all pci functions

[Alex Chiang <achiang@xxxxxx>]

* Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>:
> On Thu, 14 May 2009 11:45:47 -0700
> Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
> 
> > Jesse Barnes wrote:
> > > Anyway it's not a big deal, this code is already ugly (a 0 define
> > > for all arches?  why?) so you shouldn't have to spend too much time
> > > cleaning it up.
> > >   
> > 
> > OK, how's this as a delta (I can fold it into the previous patch if 
> > you're OK with it):
> > 
> > Subject: [PATCH] pci: add HAVE_ARCH_PCIBIOS_SCAN_ALL_FNS
> > 
> > Jesse objected to the "#undef pcibios_scan_all_fns"'s ugliness,
> > so replace it with the more common HAVE_ARCH_ idiom.
> > 
> > Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> > Cc: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
> 
> That's slightly better.  It looks like we should just get rid of
> pcibios_scan_all_fns altogether, but this is fine for now.

It's been on my TODO list for a while now, but then holiday and
now surgery got in the way.

/ac


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel