Re: [Xen-devel] [PATCH] xen: fix s3 resume on AMD CPUs

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 05/06/2009 09:00, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> attached patch fixes S3 resume on AMD CPUs.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

Please make a minimal patch and explain each individual change. This one has
bizarre additional alignment, nops, double short jumps, longjmp->shortjmp
but keeps a comment which is then incorrect. Why are they needed? Is the
need documented? I don't see anything similar in Linux 2.6.27 wakeup
routines (2.6.27 is what I happen to have to hand).

I won't take your random permutations on this file of all files especially,
since it is a pain in the arse to debug when it gets broken.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel