[Xen-devel] Re: [PATCH RFC] x86/acpi: don't ignore I/O APICs just because there's no local APIC

[Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>]

> +             if (error == -EINVAL) {
> +                     /*
> +                      * The ACPI tables themselves were malformed.
> +                      * Dell Precision Workstation 410, 610 come here.
> +                      */
> +                     printk(KERN_ERR PREFIX
> +                            "Invalid BIOS MADT, disabling ACPI\n");
> +                     disable_acpi();
> +             } else {

This seems a very bad model. On todays systems turning off ACPI renders
them basically useless. If the MADT is bogus its far better to pray that
they rest of the ACPI is mostly sound and continue by ignoring the only
dodgy table.

Alan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel