Re: [Xen-devel] [PATCH] 1 of 5: secondary consoles in minos

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

Dulloor wrote:

> For completeness, we should be freeing up memory(malloced for dev) in
> case of an error in xencons_ring_init. There could be other such instances.

Good point.

> Also, is it too difficult to create a consfront_dev for the first
> console and get rid of those !dev checks.


No, it is not difficult, I actually wrote it that way the first time.
However I would need to keep the checks anyway because the first console
is used even before init_console is called. Therefore I decided to avoid
calling init_console for the first console and use the !dev checks for it.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel