Re: [Xen-devel] [Xen-dev][PATCH] fix qcow2 can not work with blktap2

[Dutch Meyer <dmeyer@xxxxxxxxx>]

Rather than patching blktap2/daemon/, let's just cut it entirely.
Blktap2 doesn't need to be replacing blktapctrl or tapdisk. These
shouldn't have been included in the blktap2 release - we were just being a
little over-zealous in mirroring Citrix's blktap2. So those can be
exclusive to the original blktap.

I'll send a counter-proposal patch.

--Dutch

On Thu, 18 Jun 2009, Zhang, Yang wrote:

> Since the hotplug script for udev has been removed by c/s 19349, we need report
> the hotplug-status while the corresponding tapdisk been create. Or else, It will
> raise an error "hotplug script not working".
>
> Signed-off-by: Yang Zhang <yang.zhang@xxxxxxxxx>
>
> diff -r 112680f620bf tools/blktap2/daemon/tapdisk-daemon.c
> --- a/tools/blktap2/daemon/tapdisk-daemon.c     Mon Jun 08 18:23:57 2009 +0100
> +++ b/tools/blktap2/daemon/tapdisk-daemon.c     Thu Jun 18 11:32:15 2009 +0800
> @@ -295,7 +295,10 @@ tapdisk_daemon_probe(struct xs_handle *x
>         len = strsep_len(path, '/', 7);
>         if (len < 0)
>                 return;
> -
> +       if (path[len] == '\0') {
> +               xs_printf(xsh, path, "hotplug-status", "connected");
> +               return;
> +       }
>         node = path + len + 1;
>
>         if (!tapdisk_daemon_new_vbd_event(node))
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel