Re: [Xen-devel] [PATCH] TSC scaling for live migration between platforms with different TSC frequecies

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 10:10 +0100 on 18 Jun (1245319857), Patrick Colp wrote:
> >+        printk("Migrate to a platform with different freq:%ldMhz, "
> >+            "expected freq:%dMhz, enable rdtsc exiting!\n",
> >+                    cpu_khz / 1000, hdr->gtsc_khz / 1000);
> 
> Being pedantic, this should probably be:
> 
>      printk("Migrate to a platform with different freq: %ldMHz, "
>             "expected freq: %dMHz, enable rdtsc exiting!\n",
>              cpu_khz / 1000, hdr->gtsc_khz / 1000);

Being _pedantic_, it should be 

      gdprintk(XENLOG_INFO, "Loaded VM expects a %"PRIu32"MHz TSC "
               "but CPU is %ldMHz; enabling RDTSC exiting.\n", 
               hdr->gtsc_khz / 1000, cpu_khz / 1000);

:) 

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Citrix Systems (R&D) Ltd.
[Company #02300071, SL9 0DZ, UK.]

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel