[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] MSR related clean up



On 24/06/2009 09:50, "Sheng Yang" <sheng@xxxxxxxxxxxxxxx> wrote:

> On Thursday 18 June 2009 17:57:06 Sheng Yang wrote:
>> rdmsr_safe() is used to access MSR unknown to Xen, and is not safe... I
>> think it is legacy.
>> 
>> Also let msr_write be parity with msr_read on MSR_IA32_MISC_ENABLE.
>> 
>> CC: Eddie Dong <eddie.dong@xxxxxxxxx>
>> Signed-off-by: Sheng Yang <sheng@xxxxxxxxxxxxxxx>
> 
> Keir?

Looks pretty dangerous to me. So I'm not sure. There are various MSRs that
are detected via CPU family/model (which we pass through) which would then
#GP on access. Also this doesn't change the AMD default. Overall, what we
have now does seem to work so I'm reluctant to mess with it.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.