Re: [Xen-devel] [PATCH] blktap2: portability fixes

[Christoph Egger <Christoph.Egger@xxxxxxx>]

Patch is attached.
uuid is totally different in Linux and in NetBSD.
uuid_t is a char array in Linux and a struct in NetBSD.
Making NetBSD uuid look like Linux uuid doesn't work at all and
neither the other way around.
I renamed your uuid.h header to avoid a recursive inclusion
of the same header.
I created an uuid abstraction with a Linux and NetBSD implementation.

I also fixed a bug in vhd_create_batmap() which slipped in previously.
iconv() is a bit nasty to make it compile on both NetBSD and Linux.

Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>


On Tuesday 23 June 2009 18:25:19 Keir Fraser wrote:
> This didn't have a prayer of building on Linux. I fixed it up for Linux and
> applied as c/s 19817. It's probably broken for netbsd now, but you should
> be able to provide a small fixup patch for that.
>
>  -- Keir
>
> On 23/06/2009 13:29, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
> > Hi!
> >
> > Attached patch makes blktap2 build on NetBSD.
> >
> > - Use standard off_t and lseek() instead of non-portable off64_t and
> > lseek64() - Use uuid API as documented in DCE 1.1 RPC specification
> > - Add NetBSD implementation for blk_getimagesize() and
> > blk_getsectorsize() - Use blk_getimagesize() and blk_getsectorsize()
> > - Fix uuid header check
> >
> > Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>



-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Attachment: xen_blktap2.diff
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel