Re: [Xen-devel] [PATCH] blktap2: add blktap2 device classanddevicecontroller

[Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>]

Hi Ryan,

I tested your patch by using a PV domain. 
The results are as follows.

Managed domains|Domain status |Commands        |tap:aio |tap:sync
---------------+--------------+----------------+--------+--------
Yes            |Active        |xm block-attach | OK     | OK
               |              +----------------+--------+--------
               |              |xm block-deatch | OK     |Failed-1
               |              +----------------+--------+--------
               |              |xm shutdown     | OK     | OK
               +--------------+----------------+--------+--------
               |Inactive      |xm start        | OK     | OK
               |              +----------------+--------+--------
               |              |xm block-attach | OK     | OK?-2
               |              +--------------- +--------+--------
               |              |xm block-detach | OK     | OK?-2
---------------+--------------+----------------+--------+--------
No             | -            |xm create       | OK     | OK
               |              +----------------+--------+--------
               |              |xm block-attach | OK     | OK
               |              +--------------- +--------+--------
               |              |xm block-detach | OK     | OK
               |              +----------------+--------+--------
               |              |xm shutdown     | OK     | OK
---------------+--------------+----------------+--------+--------

Failed-1:
xm block-detach command succeeded.
But I detected the following error message in xend.log.

[2009-07-01 16:12:30 3618] DEBUG (XendDomainInfo:1190) 
XendDomainInfo.destroyDevice: deviceClass = tap, device = 833
[2009-07-01 16:12:30 3618] DEBUG (DevController:180) Waiting for 833 - 
destroyDevice.
[2009-07-01 16:12:31 3618] DEBUG (DevController:649) deviceDestroyCallback 
/local/domain/0/backend/tap/8/833/hotplug-status.
[2009-07-01 16:12:31 3618] DEBUG (DevController:649) deviceDestroyCallback 
/local/domain/0/backend/tap/8/833/hotplug-status.
[2009-07-01 16:12:31 3618] DEBUG (DevController:658) deviceDestroyCallback 6.
[2009-07-01 16:12:31 3618] ERROR (XendConfig:1129) dumping sxp from device 
controllers
Traceback (most recent call last):
  File "usr/lib/python2.4/site-packages/xen/xend/XendConfig.py", line 1115, in 
to_sxp
    configs = controller.configurations(txn)
  File "usr/lib/python2.4/site-packages/xen/xend/server/DevController.py", line 
242, in configurations
    return map(lambda x: self.configuration(x, transaction), 
self.deviceIDs(transaction))
  File "usr/lib/python2.4/site-packages/xen/xend/server/DevController.py", line 
242, in <lambda>
    return map(lambda x: self.configuration(x, transaction), 
self.deviceIDs(transaction))
  File "usr/lib/python2.4/site-packages/xen/xend/server/DevController.py", line 
249, in configuration
    configDict = self.getDeviceConfiguration(devid, transaction)
  File "usr/lib/python2.4/site-packages/xen/xend/server/blkif.py", line 160, in 
getDeviceConfiguration
    \047bootable\047)
  File "usr/lib/python2.4/site-packages/xen/xend/server/DevController.py", line 
447, in readBackendTxn
    raise VmError("Device %s not connected" % devid)
VmError: Device 833 not connected


OK?-2:
The deivce class is 'tap2'.  Ideally, the device class should be 'tap'.
Could you confirm information of xm list --long?


Best regards,
 Kan

Tue, 30 Jun 2009 23:04:18 -0700, Ryan O'Connor wrote:

>Hi Kan,
>
>On Wed, Jul 01, 2009 at 02:44:55PM +0900, Masaki Kanno wrote:
>> Hi Ryan,
>> 
>> I thought... 
>> Are blktap1 and blktap2 used as follows? 
>> And the head of the string of disk parameters for blktap devices is 
>> 'tap:' only, isn't it?
>> Is my understanding right?
>> 
>>      |        blktap2        |
>>      +-----------+-----------+
>>      | Installed | Not       |
>>      |           | Installed |
>> -----+-----------+-----------+
>> aio  |blktap2    |blktap1    |
>> -----+-----------+-----------+
>> sync |blktap1    |blktap1    |
>> -----+-----------+-----------+
>> vmdk |blktap1    |blktap1    |
>> -----+-----------+-----------+
>> ram  |blktap2    |blktap1    |
>> -----+-----------+-----------+
>> qcow |blktap2    |blktap1    |
>> -----+-----------+-----------+
>> qcow2|blktap1    |blktap1    |
>> -----+-----------+-----------+
>> vhd  |blktap2    |blktap1    |
>> -----+-----------+-----------+
>> ioemu|blktap1    |blktap1    |
>> -----+-----------+-----------+
>
>Yes, you are correct. Also, note that this is the same way
>BlktapController created blktap1 and blktap2 devices before my patch.
>
>> Wed, 01 Jul 2009 13:33:35 +0900, Masaki Kanno wrote:
>> 
>> >Hi Ryan,
>> >
>> >>blktap2 devices must be handled differently than blktap2 devices. blktap2
>> >                                                  ^^^^^^^
>> >                                                  blktap1?  typo?
>
>Thanks, this is a typo. It should say "blktap1".
>
>Thanks again
>Ryan
>--
>  Ryan O'Connor <rjo@xxxxxxxxx>
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel