[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] RE: [PATCH] tools: portability fixes

>-----Original Message-----
>From: Christoph Egger [mailto:Christoph.Egger@xxxxxxx]
>Sent: Thursday, July 02, 2009 6:03 PM
>To: xen-devel@xxxxxxxxxxxxxxxxxxx
>Cc: Lu, Guanqun
>Subject: [PATCH] tools: portability fixes
>Attached patch makes gtraceview compile on NetBSD.
>Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
>1. Why do you hardcode -lncurses, when there is a CURSES_LIBS variable ?
>    The existence of it should have ring an alarm bell that your code isn't
>    portable, i.e. that you can't blindly include <ncurses.h>.

It seems I'm still missing something when I try not to. Thanks for your finding.

>2. The string operations look dangerous in respect to security. Please fix

It uses the fixed length currently for the ease of programming at first. It 
will be fixed. Thanks for the reminder.

>---to satisfy European Law for business letters:
>Advanced Micro Devices GmbH
>Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
>Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
>Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
>Registergericht Muenchen, HRB Nr. 43632

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.