RE: [Xen-devel] [PATCH] Fix xentop on pv-ops domain0

["Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx>]

Hi, Keir, 
        The following patch is from Ian Campbell, sent at Fri 5/8/2009 5:03 PM. 



This path doesn't exist in the pvops kernel. Looks
like /sys/bus/xen-backend/devices is just as good and exists in both
pvops and 2.6.18 kernels.

Subject: xenstat: Use backend path which is compatible with pvops and 
2.6.18-xen kernels.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r 07812e857e67 tools/xenstat/libxenstat/src/xenstat_linux.c
--- a/tools/xenstat/libxenstat/src/xenstat_linux.c      Thu Apr 09 12:09:14 
2009 +0100
+++ b/tools/xenstat/libxenstat/src/xenstat_linux.c      Fri May 08 09:40:45 
2009 +0100
@@ -31,7 +31,7 @@
 
 #include "xenstat_priv.h"
 
-#define SYSFS_VBD_PATH "/sys/devices/xen-backend/"
+#define SYSFS_VBD_PATH "/sys/bus/xen-backend/devices"
 
 struct priv_data {
        FILE *procnetdev;

Best Regards, 
-- Dongxiao

-----Original Message-----
From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx] 
Sent: Tuesday, July 07, 2009 3:16 PM
To: Xu, Dongxiao; echo@xxxxxxxxxxxx; Christoph Egger; Steven Maresca
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] Fix xentop on pv-ops domain0

Please send a final patch.

 Thanks,
 Keir

On 07/07/2009 01:37, "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx> wrote:

> Using "/sys/bus/xen-backend/devices/" is fine, formerly I didn't notice there
> was a link in this directory. Thanks!
> 
> Best Regards, 
> -- Dongxiao
> 
> -----Original Message-----
> From: Tim Post [mailto:echo@xxxxxxxxxxxx]
> Sent: Tuesday, July 07, 2009 12:02 AM
> To: Christoph Egger
> Cc: Xu, Dongxiao; xen-devel@xxxxxxxxxxxxxxxxxxx; keir.fraser@xxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH] Fix xentop on pv-ops domain0
> 
> Hi,
> 
> On Mon, 2009-07-06 at 17:49 +0200, Christoph Egger wrote:
>> This patch is good.
>> 
> 
> The following is going to break xenstat on almost every forward port of
> 2.6.18.8 (including Andy's 2.6.30 vanilla port):
> 
> 
> +       if (strncmp(system_info.release, "2.6.18.8-xen",
> +               sizeof("2.6.18.8-xen")) == 0)
> +               sysfs_vbd_path = "/sys/devices/xen-backend/";
> +       else
> +               sysfs_vbd_path = "/sys/devices/";
> +
> 
> I would really recommend considering just
> using /sys/bus/xen-backend/devices, as Stephen noted.
> 
> Cheers,
> --Tim
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel