[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] RE: [PATCH v2.0 1/6] Add a config option for memory hot add


  • To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
  • From: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
  • Date: Wed, 8 Jul 2009 22:31:25 +0800
  • Accept-language: en-US
  • Acceptlanguage: en-US
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 08 Jul 2009 07:32:41 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acn/n+A3yJUALD5FQNSIqtARBUwsjgAMLZJkAAHSpaA=
  • Thread-topic: [PATCH v2.0 1/6] Add a config option for memory hot add

Keir Fraser wrote:
> On 08/07/2009 08:44, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx> wrote:
> 
>> This patch add an option for memory hot add.
>> 
>> Signed-off-by: Jiang, Yunhong <yunhong.jiang@xxxxxxxxx>
> 
> Doesn't need to be a config option. We only have some CONFIG_*
> options to
> avoid modifying Linux-derived files. For new Xen features,
> don't bother. Add
> X86_MAX_PFN in the patch that uses it, and if it is x86_32 only then
> it should only be defined for that build target (not x86_64 as well).

Sorry that I didn't realize the purpose of the CONFIG_* options. But this 
optoin may be needed because:
a) When memory hotplug, we need set the boot allocation bitmap memory to 512k 
when booting. So for small system, we can avoid that extra memory. Of course, 
maybe that can be removed after the allocation bitmap is removed al-together.
b) When Memory hotplug, we can't adjust compatible guest's hv_virt_start 
anymore. I'm not sure how important it is, so I keep that for 
non-memory-hotplug support.

Any idea?

I will change the X86_MAX_PFN.

> 
> -- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.