[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] cs 19927 crashes during boot with debug=y


  • To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • From: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
  • Date: Wed, 15 Jul 2009 12:42:06 +0100
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
  • Delivery-date: Wed, 15 Jul 2009 04:42:35 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=xlLggX1VS5FgdiWvu8VmjqMvcreeNcMtvfvwJoetb12WTgclfIwrFeqpnWeW6Dzrqr +a73n8WUP4xjiLx/OdXOdP/Z18jy86jhG191sydfAfAKBxEejLRcnkPgTx6Pfjs4kBsq o9oX/57G3pbyuAFV1Qu/+sAe1Zpi2NyyufGXY=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Sweet, that fixed it.  Thanks.
 -George

On Wed, Jul 15, 2009 at 8:31 AM, Keir Fraser<keir.fraser@xxxxxxxxxxxxx> wrote:
> On 15/07/2009 08:26, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
>
>> Just by looking at the code I spotted one place that needs fixing:
>>
>> for (cpu = 0; cpu < NR_CPUS; cpu++) {
>> cpus_clear(per_cpu(cpu_sibling_map, cpu));
>> cpus_clear(per_cpu(cpu_core_map, cpu));
>> }
>>
>> which clearly needs to be using for_each_possible_cpu(). (Huh, this is still
>> named for_each_cpu() - Keir, shouldn't we get this in sync with the Linux
>> naming?)
>
> Feel free to submit patches for both issues. I too prefer the new Linux
> name.
>
>  -- Keir
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.