Re: [Xen-devel] [PATCH] minios: minor buildsystem fixes

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 15 Jul 2009, Christoph Egger wrote:
> 
> Hi!
> 
> Attached patch changes MiniOS.mk and tools/Rules.mk
> use the OS settings we build on.
> 

Looking at the original patch of this thread, I realize that probably
none of this is actually needed: 

> diff -r 323ae92f774b config/MiniOS.mk
> --- a/config/MiniOS.mk        Wed Jul 15 09:14:19 2009 +0100
> +++ b/config/MiniOS.mk        Wed Jul 15 11:35:03 2009 +0200
> @@ -1,4 +1,4 @@
> -include $(XEN_ROOT)/config/StdGNU.mk
> +include $(XEN_ROOT)/config/$(shell uname -s).mk
>  include $(XEN_ROOT)/extras/mini-os/Config.mk
>  CFLAGS += $(DEF_CFLAGS) $(ARCH_CFLAGS)
>  CPPFLAGS += $(DEF_CPPFLAGS) $(ARCH_CPPFLAGS) $(extra_incl)

This is not needed because the only things that NetBSD.mk adds more than
StdGNU.mk are not needed in the stubdom case.


> diff -r 323ae92f774b tools/Rules.mk
> --- a/tools/Rules.mk  Wed Jul 15 09:14:19 2009 +0100
> +++ b/tools/Rules.mk  Wed Jul 15 11:35:03 2009 +0200
> @@ -33,7 +33,10 @@ CFLAGS += -D__XEN_TOOLS__
>  CFLAGS += -MMD -MF .$(@F).d
>  DEPS = .*.d
>  
> -ifneq ($(XEN_OS),NetBSD)
> +# On NetBSD LFS is always on.
> +# We can't use $(XEN_OS) or we will miss MiniOS
> +# when we build MiniOS on NetBSD.
> +ifneq ($(shell uname -s),NetBSD)
>  # Enable implicit LFS support *and* explicit LFS names.
>  CFLAGS  += $(shell getconf LFS_CFLAGS)
>  CFLAGS  += -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE

Given that you are still using GNU gcc on NetBSD, even if LFS is already
enabled by default, how is this an error?
Does it actually prevent you from compiling successfully qemu?

If you really need to disable those flags you should do that based on
getconf responses.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel