RE: [Xen-devel] RE: [Xen-changelog] [xen-unstable] xend: hot-plug PCI devices at boot-time

["Cui, Dexuan" <dexuan.cui@xxxxxxxxx>]

Hi Simon,
Actually I think you have done a great work to clean up the related xend code, 
however looks we should do more. :-)

Thanks,
-- Dexuan


-----Original Message-----
From: Simon Horman [mailto:horms@xxxxxxxxxxxx] 
Sent: 2009?7?28? 16:57
To: Cui, Dexuan
Cc: Keir Fraser; xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] RE: [Xen-changelog] [xen-unstable] xend: hot-plug PCI 
devices at boot-time

On Tue, Jul 28, 2009 at 04:42:17PM +0800, Cui, Dexuan wrote:
> Duplicate calls to setupOneDevice() in the case of HVM  are really odd to me. 

Personally I'd rather call the code twice than have extra if logic.
But your patch is ok with me.

> BTW, actually I suspect setupOneDevice() is unnecessary for HVM guest
> since looks all of the actual work of setupOneDevice() is done by
> ioemu-dm.

I suspect you are right there.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel