Re: [Xen-devel] Cpu pools discussion

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 28/07/2009 14:41, "George Dunlap" <dunlapg@xxxxxxxxx> wrote:

> As Juergen says, for people who don't use the feature, it shouldn't
> have any real effect.  The patch is pretty straightforward, except for
> the "continue_hypercall_on_cpu()" bit.

Just pulled up the patch. Actually cpupool_borrow_cpu() does not seem to
lock down the cpu-pool-vcpu relationship while continue_hypercall_on_cpu()
is running. In particular, it is clear that it does nothing if the vcpu is
already part of the pool that the domain is running in. But then what if the
cpu is removed from the pool during the borrow_cpu()/return_cpu() critical
region? It hardly inspires confidence.

Another thing I noted is that sched_tick_suspend/resume are pointlessly
changed to take a cpu parameter, which is smp_processor_id(). I swear at the
screen whenever I see people trying to slip that kind of nonsense in. It
makes it look like the functions can operate on an arbitrary cpu when in
fact I'll wager they cannot (and I doubt the author of such changes has
checked). It's a nasty nasty interface change.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel