RE: [Xen-devel] [PATCH] fix qemu memory leak

[Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>]

Is this just for stubdom, or is it a generic qemu problem?
(Your patch just gives the filename, no path to it.)

> -----Original Message-----
> From: Stefano Stabellini [mailto:stefano.stabellini@xxxxxxxxxxxxx]
> Sent: Wednesday, August 12, 2009 10:12 AM
> To: Stefano Stabellini
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH] fix qemu memory leak
> 
> 
> On Wed, 12 Aug 2009, Stefano Stabellini wrote:
> > Hi all,
> > the qemu block interface leaks memory every time a read or 
> write request
> > is issued, this patch fixes it.
> > This is also the bug that is causing stubdomains to crash under high
> > disk IO.
> 
> I forgot to say that this patch should be backported to 3.4 too.
> 
> 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > 
> > ---
> > 
> > diff --git a/block.c b/block.c
> > index 36f5eb9..6ce453c 100644
> > --- a/block.c
> > +++ b/block.c
> > @@ -1378,6 +1378,7 @@ static void 
> bdrv_aio_rw_vector_cb(void *opaque, int ret)
> >      qemu_vfree(s->bounce);
> >      s->this_aiocb->cb(s->this_aiocb->opaque, ret);
> >      qemu_aio_release(s->this_aiocb);
> > +    qemu_free(s);
> >  }
> >  
> >  static BlockDriverAIOCB *bdrv_aio_rw_vector(BlockDriverState *bs,
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xen-devel
> > 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel