RE: [Xen-devel] [pvops-dom0] Adding MCA logging support in pv_ops

["Ke, Liping" <liping.ke@xxxxxxxxx>]

Hi, Jeremy

Please use this newer one. Modified contact header.
Thanks & Regards,
Criping



>From 1d3152ae0c69a4618bb2137ec5bf150d595de26f Mon Sep 17 00:00:00 2001
From: Liping Ke <liping.ke@xxxxxxxxx>
Date: Wed, 19 Aug 2009 09:16:22 +0800
Subject: [PATCH] Small fix for MCA Logging in pv-ops

We need to move mce vIRQ handler registration after all
other ops succeeds as Jan points out.

Signed-off-by: Liping Ke<liping.ke@xxxxxxxxx>
---
 drivers/xen/mce.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/xen/mce.c b/drivers/xen/mce.c
index ef838f2..b354dc8 100644
--- a/drivers/xen/mce.c
+++ b/drivers/xen/mce.c
@@ -148,14 +148,6 @@ static int bind_virq_for_mce(void)
        int ret;
        xen_mc_t mc_op;
 
-       ret  = bind_virq_to_irqhandler(VIRQ_MCA, 0,
-               mce_dom_interrupt, 0, "mce", NULL);
-
-       if (ret < 0) {
-               printk(KERN_ERR "MCE_DOM0_LOG: bind_virq for DOM0 failed\n");
-               return ret;
-       }
-
        g_mi = kmalloc(sizeof(struct mc_info), GFP_KERNEL);
 
        if (!g_mi)
@@ -189,6 +181,14 @@ static int bind_virq_for_mce(void)
                return ret;
        }
 
+       ret  = bind_virq_to_irqhandler(VIRQ_MCA, 0,
+               mce_dom_interrupt, 0, "mce", NULL);
+
+       if (ret < 0) {
+               printk(KERN_ERR "MCE_DOM0_LOG: bind_virq for DOM0 failed\n");
+               return ret;
+       }
+
        return 0;
 }
 
-- 
1.5.1



Ke, Liping wrote:
> Hi, Jeremy
> This is the delta patch. Thanks a lot!
> 
> Regards,
> Criping
> 
> 
>> From 1d3152ae0c69a4618bb2137ec5bf150d595de26f Mon Sep 17 00:00:00
>> 2001 
> From: root <root@xxxxxxxxxxxxxxxxxxx>
> Date: Wed, 19 Aug 2009 09:16:22 +0800
> Subject: [PATCH] Small fix for MCA Logging in pv-ops
> 
> We need to move mce vIRQ handler registration after all
> other ops succeeds as Jan points out.
> 
> Signed-off-by: Liping Ke<liping.ke@xxxxxxxxx>
> ---
>  drivers/xen/mce.c |   16 ++++++++--------
>  1 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/xen/mce.c b/drivers/xen/mce.c
> index ef838f2..b354dc8 100644
> --- a/drivers/xen/mce.c
> +++ b/drivers/xen/mce.c
> @@ -148,14 +148,6 @@ static int bind_virq_for_mce(void)
>       int ret;
>       xen_mc_t mc_op;
> 
> -     ret  = bind_virq_to_irqhandler(VIRQ_MCA, 0,
> -             mce_dom_interrupt, 0, "mce", NULL);
> -
> -     if (ret < 0) {
> -             printk(KERN_ERR "MCE_DOM0_LOG: bind_virq for DOM0 failed\n");
> -             return ret;
> -     }
> -
>       g_mi = kmalloc(sizeof(struct mc_info), GFP_KERNEL);
> 
>       if (!g_mi)
> @@ -189,6 +181,14 @@ static int bind_virq_for_mce(void)
>               return ret;
>       }
> 
> +     ret  = bind_virq_to_irqhandler(VIRQ_MCA, 0,
> +             mce_dom_interrupt, 0, "mce", NULL);
> +
> +     if (ret < 0) {
> +             printk(KERN_ERR "MCE_DOM0_LOG: bind_virq for DOM0 failed\n");
> +             return ret;
> +     }
> +
>       return 0;
>  }
> 
> 
> Jeremy Fitzhardinge wrote:
>> On 08/18/09 02:25, Ke, Liping wrote:
>>> Hi, Jan
>>> Yes, the added physinfo fetch op should be placed before
>>> registering the vIRQ handler. Thanks for pointing out. Below is the
>>> updated patch. 
>>> 
>> 
>> Please send a delta against the previous patch.
>> 
>>     J

Attachment: 0001-Small-fix-for-MCA-Logging-in-pv-ops.patch
Description: 0001-Small-fix-for-MCA-Logging-in-pv-ops.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel