[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] xen pm trace utility cleanup



xenpm trace utility gtraceview cleanup

- add gtraceview help info on how to get raw data by xentrace
- make trace_exit_reason compiled in non-debug mode. trace_exit_reason can be 
enable/disabled by xentrace at runtime, so no need to disable it at build time.

Signed-off-by: Yu Ke <ke.yu@xxxxxxxxx>

diff -r 8b0f1f37e145 tools/misc/gtracestat.c
--- a/tools/misc/gtracestat.c
+++ b/tools/misc/gtracestat.c
@@ -442,7 +442,7 @@ void show_help(void)
 {
     show_version();
     printf("tracestat <trace.data> [-vhdselbcmau]\n");
-    printf("  trace.data       raw data from xentrace\n");
+    printf("  trace.data       raw data got by 'xentrace -e 0x80f000 
trace.dat'\n");
     printf("  -v / --version   show version message\n");
     printf("  -h / --help      show this message\n");
     printf("  -d / --digest    digest mode, more variables to specify.\n");
diff -r 8b0f1f37e145 tools/misc/gtraceview.c
--- a/tools/misc/gtraceview.c
+++ b/tools/misc/gtraceview.c
@@ -542,7 +542,8 @@ void show_help(void)
 {
     show_version();
     printf("gtraceview <trace.data> [--version] [--help]\n");
-    printf("  trace.data   raw data from xentrace\n");
+    printf("  trace.data   raw data got by "
+           "'xentrace -e 0x80f000 trace.dat'\n");
     printf("  --version    show version information\n");
     printf("  --help       show this message\n");
     printf("For more help messages, please press 'h' in the window\n");
diff -r 8b0f1f37e145 xen/arch/x86/acpi/cpu_idle.c
--- a/xen/arch/x86/acpi/cpu_idle.c
+++ b/xen/arch/x86/acpi/cpu_idle.c
@@ -198,7 +198,6 @@ static struct {
 
 static inline void trace_exit_reason(u32 *irq_traced)
 {
-#ifdef DEBUG
     if ( unlikely(tb_init_done) )
     {
         int i, curbit;
@@ -215,7 +214,6 @@ static inline void trace_exit_reason(u32
             curbit = find_next_bit((const unsigned long *)irr_status, 256, 
curbit + 1);
         }
     }
-#endif
 }
 
 static void acpi_processor_idle(void)

Attachment: gtraceview.patch
Description: gtraceview.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.