Re: [Xen-devel] [PATCH]: Implement bzip2 and LZMA loaders / fixed patch for Xen 3.4.1

[Pasi Kärkkäinen <pasik@xxxxxx>]

On Thu, Aug 20, 2009 at 09:34:08PM +0300, Pasi Kärkkäinen wrote:
> On Thu, Aug 13, 2009 at 09:47:27AM +0200, Chris Lalancette wrote:
> > All,
> >      Recent upstream kernels can be compressed using either gzip, bzip2, or
> > LZMA.  However, the PV kernel loader in Xen currently only understands 
> > gzip, and
> > will fail on the other two types.  The attached patch implements kernel
> > decompression for gzip, bzip2, and LZMA so that kernels compressed with any 
> > of
> > these methods can be launched.  Note that the patch is still a little bit 
> > rough,
> > but I thought I would post it to get feedback about what I'm doing wrong.
> >      I developed this against the RHEL-5 version of the xen tools, but a 
> > quick
> > look through xen-unstable shows that this should apply pretty easily to the
> > current code.
> > 
> 
> Attached are two patches:
> 
> - Patch by Chris modified to apply to Xen 3.4.1 (only a small Makefile change)
> - Patch by me to fix compilation with gcc 4.4.0.
> 

Hmm, actually this patch seems to break stubdom build/linking:

ld -nostdlib 
-L/root/tem/xen-3.4-testing.hg/stubdom/cross-root-i686/i686-xen-elf/lib  -m 
elf_i386 
-T arch/x86/minios-x86_32.lds 
/root/tem/xen-3.4-testing.hg/stubdom/mini-os-x86_32-ioemu/mini-os.o  
-o /root/tem/xen-3.4-testing.hg/stubdom/mini-os-x86_32-ioemu/mini-os
ld: warning: section `.bss' type changed to PROGBITS 
/root/tem/xen-3.4-testing.hg/stubdom/mini-os-x86_32-ioemu/mini-os.o: In 
function `xc_try_bzip2_decode':
/root/tem/xen-3.4-testing.hg/stubdom/libxc-x86_32/xc_dom_bzimageloader.c:56: 
undefined reference to `BZ2_bzDecompressInit'
/root/tem/xen-3.4-testing.hg/stubdom/libxc-x86_32/xc_dom_bzimageloader.c:111: 
undefined reference to `BZ2_bzDecompressEnd'
/root/tem/xen-3.4-testing.hg/stubdom/libxc-x86_32/xc_dom_bzimageloader.c:80: 
undefined reference to `BZ2_bzDecompress'
/root/tem/xen-3.4-testing.hg/stubdom/libxc-x86_32/xc_dom_bzimageloader.c:111: 
undefined reference to `BZ2_bzDecompressEnd'
/root/tem/xen-3.4-testing.hg/stubdom/mini-os-x86_32-ioemu/mini-os.o: In 
function `xc_try_lzma_decode':
/root/tem/xen-3.4-testing.hg/stubdom/libxc-x86_32/xc_dom_bzimageloader.c:126: 
undefined reference to `lzma_alone_decoder'
/root/tem/xen-3.4-testing.hg/stubdom/libxc-x86_32/xc_dom_bzimageloader.c:211: 
undefined reference to `lzma_end'
/root/tem/xen-3.4-testing.hg/stubdom/libxc-x86_32/xc_dom_bzimageloader.c:150: 
undefined reference to `lzma_code'
/root/tem/xen-3.4-testing.hg/stubdom/libxc-x86_32/xc_dom_bzimageloader.c:211: 
undefined reference to `lzma_end'
make[2]: ***
[/root/tem/xen-3.4-testing.hg/stubdom/mini-os-x86_32-ioemu/mini-os] Error 1
make[2]: Leaving directory `/root/tem/xen-3.4-testing.hg/extras/mini-os'
make[1]: *** [ioemu-stubdom] Error 2
make[1]: Leaving directory `/root/tem/xen-3.4-testing.hg/stubdom'
make: *** [install-stubdom] Error 2


Any ideas how to fix that? Do we need to include bzip2 and lzma libs in 
stubdom/ ?

-- Pasi

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel