Re: [Xen-devel] [PATCH]: Implement bzip2 and LZMA loaders / fixed patch for Xen 3.4.1

[Pasi Kärkkäinen <pasik@xxxxxx>]

On Fri, Aug 21, 2009 at 12:22:43PM +0300, Pasi Kärkkäinen wrote:
> On Thu, Aug 20, 2009 at 10:27:29PM +0100, Keir Fraser wrote:
> > On 20/08/2009 22:15, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:
> > 
> > >> Hmm, actually this patch seems to break stubdom build/linking:
> > > 
> > > I checked in a variant as c/s 20103, which at least for non-stubdom build 
> > > of
> > > libxenguest should do the right thing if liblzma-devel or libbz2-devel
> > > packages (or whatever they are called) are not installed. See how that 
> > > goes
> > > with stubdom. We may just have to massage the Makefile a little more to 
> > > kill
> > > off the bz2/lzma stuff for stubdom. I'm not sure why libxenguest is 
> > > getting
> > > built for stubdom in the first place though. It's not likely to be very
> > > useful!
> > 
> > Okay, I tested and fixed the stubdom case, so hopefully c/s 20104 will
> > actually work for you.
> > 
> 
> xen-unstable "make tools && make stubdom" compiles for me with and without
> libbz2-devel/liblzma-devel installed.
> 
> But even when I have liblzma-devel installed it doesn't seem to use it. 
> ie. I only see -DHAVE_BZLIB in the build log and libxenguest.so.3.4.0 gets
> only linked against -lbz2.
> 
> Investigating more..
> 

Ok, that was a stupid problem. I tried to build on Ubuntu box now (instead
of Fedora), and it seems lzma-dev was not the correct/needed package, 
but I had to install liblzma-dev.

So it seems to build OK for me. I'll verify also on Fedora later today.

-- Pasi

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel