[Xen-devel] RE: About CONFIG_ACPI_PROCESSOR_XEN

["Yu, Ke" <ke.yu@xxxxxxxxx>]

Hi Gianluca

Thanks for trying and reporting this issue. The root cause of the compilation 
issue is found as: "when CONFIG_ACPI_PROCESSOR_XEN is not set, the 
<include/acpi/processor.h> is not included, thus the "struct acpi_processor" is 
not defined, which will cause compiling error for inline function 
processor_cntl_xen_prepare(struct acpi_processor *pr);"

I've worked out the attached patch, could you please try it? Thanks 

For the second question, CONFIG_ACPI_PROCESSOR_XEN control whether enabling Xen 
Cx/Px power management or not. CONFIG_ACPI_PROCESSOR_XEN depends on both 
CONFIG_ACPI_PROCESSOR and CPU_FREQ, if CPU_FREQ=n, the 
CONFIG_ACPI_PROCESSOR_XEN will not be set, so the empty version is used and Xen 
Cx/Px power management will not be enabled. This is intended usage. Anything 
wrong observed in your side?

Best Regards
Ke

-----Original Message-----
From: Gianluca Guida [mailto:gianluca.guida@xxxxxxxxxx] 
Sent: Monday, August 24, 2009 9:25 PM
To: Yu, Ke; Tian, Kevin; Jeremy Fitzhardinge
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: About CONFIG_ACPI_PROCESSOR_XEN

Hi,

While configuring dom0 kernels I've found certaing things in the
handling of CONFIG_ACPI_PROCESSOR_XEN which are confusing to me.

- In case CONFIG_ACPI_PROCESSOR is set as a module (which was the
  default in my system) the compilation will break, because
  CONFIG_ACPI_PROCESSOR_XEN will not be set.

- CONFIG_ACPI_PROCESSOR_XEN is only set when CPU_FREQ=y, but these
  functions are used (in their empty versions) even when
  CONFIG_ACPI_PROCESSOR=y and CPU_FREQ=n. Is this the intended use?

Thanks,
Gianluca

Attachment: pv_ops_compiling.patch
Description: pv_ops_compiling.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel