[Xen-devel] Re: [PATCH] x86 hvm: fix missing ticks issue in c/s 20218

[Christoph Egger <Christoph.Egger@xxxxxxx>]

On Friday 25 September 2009 14:25:11 Kouya Shimura wrote:
> Keir,
> Okay, attached is a new patch per your advice.
> I tested it carefully. It works for me.
>
> Christoph,
> Could you please test it?

Works for me. Thanks for fixing it.

Christoph


> Thanks,
> Kouya
>
> Keir Fraser writes:
> > On 25/09/2009 10:32, "Kouya Shimura" <kouya@xxxxxxxxxxxxxx> wrote:
> > > I've forgotten VCPU switch. Indeed, it's pretty fragile. :-)
> > > What about modifying pt_restore_timer() not to advance pt->scheduled?
> > > We should rename pending_intr_nr to pending_intr(boolean).
> >
> > It's not clear to me that the old logic around pt->pending_intr_nr and
> > pt->scheduled really needs to change that drastically. The more we mess
> > with this code the more likely we are to break stuff, as it's hard to get
> > good coverage of the timer_modes and various ways guest Oses may manage
> > their timers.
> >
> > I would prefer to see whether moving the update of pt->scheduled out of
> > pt_intr_post() and back into the timer_fn() works. That moves us back
> > towards what we had before your patches, and therefore I'm more
> > comfortable with it.
> >
> >  -- Keir
>
> Signed-off-by: Kouya Shimura <kouya@xxxxxxxxxxxxxx>



-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel