[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel][PATCH] VNIF: Using smart polling instead of event notification.



You are adding a netfront specific field to the generic ring structure?
That seems rather ugly. 

Is this even necessary as a piece of shared state? Once netback and
netfront have agreed, via xenstore, to use the feature netback seems to
set the flag every time it would have previously notified netfront.

Ian.

On Thu, 2009-10-01 at 01:22 +0100, Xu, Dongxiao wrote:
> Resend and put the patch in attachment. 
> 
> Patch the Xen version of ring.h
> 
> Signed-off-by: Dongxiao Xu <dongxiao.xu@xxxxxxxxx>
> 
> diff -r 8fc927798476 xen/include/public/io/ring.h
> --- a/xen/include/public/io/ring.h      Tue Sep 01 11:36:51 2009 +0100
> +++ b/xen/include/public/io/ring.h      Thu Oct 01 02:11:45 2009 +0800
> @@ -97,7 +97,8 @@ struct __name##_sring {
>  struct __name##_sring {                                                 \
>      RING_IDX req_prod, req_event;                                       \
>      RING_IDX rsp_prod, rsp_event;                                       \
> -    uint8_t  pad[48];                                                   \
> +    uint8_t  netfront_smartpoll_active;                                 \
> +    uint8_t  pad[47];                                                   \
>      union __name##_sring_entry ring[1]; /* variable-length */           \
>  };                                                                      \
>                                                                          \
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.