Re: [Xen-devel] [PATCH 07 of 10] Transitive grant support

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> <steven.smith@xxxxxxxxxx> 04.10.09 17:00 >>>
>--- a/xen/include/xen/grant_table.h    Mon Sep 22 13:09:07 2008 +0100
>+++ b/xen/include/xen/grant_table.h    Fri Nov 28 15:43:42 2008 +0000
>@@ -32,7 +32,9 @@
> struct active_grant_entry {
>     u32           pin;    /* Reference count information.             */
>     domid_t       domid;  /* Domain being granted access.             */
>-    unsigned long frame;  /* Frame being granted.                     */
>+    domid_t       trans_dom;
>+    uint32_t      trans_gref;
>+    uint32_t      frame;  /* Frame being granted.                     */

Using a uint32_t for a frame number is not valid anymore after the recent
sparse physical memory support changes (and I don't think it would have
been valid on ia64 even before).

>     unsigned long gfn;    /* Guest's idea of the frame being granted. */

This field I would think is much more reasonable to constrain to 32 bits,
if you need to save space here.

>     unsigned      is_sub_page:1; /* True if this is a sub-page grant. */
>     unsigned      start:15; /* For sub-page grants, the start offset

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel