Re: [Xen-devel] [PATCH 05 of 10] Introduce a grant_entry_v2 structure

[Steven Smith <steven.smith@xxxxxxxxxx>]

> >+struct gnttab_get_status_frames {
> >+    /* IN parameters. */
> >+    uint32_t nr_frames;
> >+    domid_t  dom;
> >+    /* OUT parameters. */
> >+    int16_t  status;              /* GNTST_* */
> >+    uint64_t frame_list;
> It would seem that this should be a GUEST_HANDLE, or is there any
> particular reason to not declare it so?
Mostly that GUEST_HANDLE isn't 32/64 invariant, and I didn't want to
have to introduce yet more compat shims.

If there's a strong consensus that GUEST_HANDLE is preferable then it
could be switched easily enough, but it seems kind of silly to
continue introducing more ABIs which aren't 64-bit clean.

Steven.

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel