Re: [Xen-devel] [PATCH] Fix hypervisor crash with unpopulated NUMA nodes

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> Andre Przywara <andre.przywara@xxxxxxx> 07.10.09 11:45 >>>
>on NUMA systems with memory-less nodes Xen crashes quite early in the 
>hypervisor (while initializing the heaps). This is not an issue if this 
>happens to be the last node, but "inner" nodes trigger this reliably.
>On multi-node processors it is much more likely to leave a node unequipped.
>The attached patch fixes this by enumerating the node via the 
>node_online_map instead of counting from 0 to num_nodes.

While I do not see anything wrong with the patch, I still wonder why it
would be needed: It seems to indicate that node_online_map represents
only nodes with memory, but imo should be representing nodes with
memory or processors (leaving aside pure I/O nodes for the moment).
So perhaps there's rather a problem with the setup of node_online_map 
somewhere?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel