RE: [Xen-devel] [PATCH] Support Integrated graphics passthrough

["Han, Weidong" <weidong.han@xxxxxxxxx>]

Hi Ian,

Thanks for pointing it out. 

pass-through.h references files of pciutils-dev package, so it shouldn't be 
included when pciutils-dev is not installed. Fixed it by checking 
CONFIG_PASSTHROUGH before including pass-through.h. Attached the updated patch. 
Thanks.

Regards,
Weidong

Ian Jackson wrote:
> Han, Weidong writes ("[Xen-devel] [PATCH] Support Integrated graphics
> passthrough"): 
>> Passthroughed IGD must use 00:02.0 in guest like in native, otherwise
>> the driver may fail to operate the IGD. This patch reserves the
>> 00:02.0 in guest and assigns it IGD automatically.
> 
> This breaks the build if passthrough is disabled due to pciutils-dev
> being missing:
> 
> Ian.
> 
> get-path: will use #!/usr/bin/python2.5 for python programs
> xen-hooks.mak:56: === pciutils-dev package not found - missing
> /usr/include/pci 
> xen-hooks.mak:57: === PCI passthrough capability has been disabled
> get-path: will use #!/usr/bin/python2.5 for python programs
> make[1]: Entering directory `/u/iwj/work/1/qemu-iwj.git/i386-dm'
> ../xen-hooks.mak:56: === pciutils-dev package not found - missing
> /usr/include/pci ../xen-hooks.mak:57: === PCI passthrough capability
> has been disabled ../xen-hooks.mak:56: === pciutils-dev package not
> found - missing /usr/include/pci ../xen-hooks.mak:57: === PCI
>   passthrough capability has been disabled CC    i386-dm/vl.o
>   CC    i386-dm/pci.o
>   CC    i386-dm/xenstore.o
> In file included from /u/iwj/work/1/qemu-iwj.git/hw/pci.c:33:
> /u/iwj/work/1/qemu-iwj.git/hw/pass-through.h:23:24: error:
> pci/header.h: No such file or directory
> /u/iwj/work/1/qemu-iwj.git/hw/pass-through.h:24:21: error: pci/pci.h:
> No such file or directory  
> In file included from /u/iwj/work/1/qemu-iwj.git/hw/pci.c:33:
> /u/iwj/work/1/qemu-iwj.git/hw/pass-through.h:397: error: expected
> '=', ',', ';', 'asm' or '__attribute__' before 'pt_pci_base_addr'
> /u/iwj/work/1/qemu-iwj.git/hw/pass-through.h:407: error: expected
> '=', ',', ';', 'asm' or '__attribute__' before
> 'pt_pci_host_read_byte'
> /u/iwj/work/1/qemu-iwj.git/hw/pass-through.h:408: error: expected
> '=', ',', ';', 'asm' or '__attribute__' before
> 'pt_pci_host_read_word' [etc]

Attachment: 0001-IGD-passthrough-support-v2.patch
Description: 0001-IGD-passthrough-support-v2.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel