[Xen-devel] RE: [Xen-changelog] [xen-unstable] passthrough/stubdom: clean up hypercall privilege checking

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 26 Oct 2009, Cui, Dexuan wrote:
> Hi Stefano,
> Looks after your patchset to enable passthrough for stubdomain was checked 
> in, guest hotplug (at least for hvm guest in the non-stubdomain case) is 
> broken, e.g., multiple times of "xm pci-attach/pci-detach" would fail.  Can 
> you try that?
> 

I tried several times and I only had problems with one particular device
for which the find_parent() function returns None therefore breaking the
following code in find_all_the_multi_functions().
This patch fixes it.
However I doubt that this bug is related to the problem you are seeing,
it would probably help if you could post xend and qemu logs.

---

diff -r 8ca4e32583b6 tools/python/xen/util/pci.py
--- a/tools/python/xen/util/pci.py      Fri Oct 23 10:15:17 2009 +0100
+++ b/tools/python/xen/util/pci.py      Mon Oct 26 11:46:38 2009 +0000
@@ -830,7 +830,10 @@
 
     def find_all_the_multi_functions(self):
         sysfs_mnt = find_sysfs_mnt()
-        parent = pci_dict_to_bdf_str(self.find_parent())
+        parentdict = self.find_parent()
+        if parentdict is None :
+            return [ self.name ]
+        parent = pci_dict_to_bdf_str(parentdict)
         pci_names = os.popen('ls ' + sysfs_mnt + SYSFS_PCI_DEVS_PATH + '/' + \
             parent + '/').read()
         funcs = extract_the_exact_pci_names(pci_names)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel