[Xen-API] RE: [Xen-devel] [PATCH] xapi toolstack (xen-api-libs): fix compile errors

[Dave Scott <Dave.Scott@xxxxxxxxxxxxx>]

Andreas wrote:
> Does this mean, that the xen-api toolchain does not work (compile)  
> with xen-unstable or some currently released Xen?  Does it only  
> compile with some Citrix internal available source?

It only currently compiles with this xen patchqueue applied:

http://xenbits.xen.org/xapi/xen-3.4.pq.hg
(applied to the tag RELEASE-3.4.1 in xen-3.4-testing.hg)

We haven't done any recent testing against xen-unstable... but we probably 
should! Perhaps we could fix this XS_RESTRICT problem with some #ifdef magic 
for the time-being. 

We're keen to get rid of these patchqueues but it will take some time.

> But I'm not sure if this is the best place for comments. IMHO when  
> somebody changes the xb.ml file, the xb.mli file will be overwritten;  
> see Makefile:
> %.mli: %.ml
>         $(OCAMLC) -i $< > $@

Oops :) 
We've been trying to add ocamldoc comments to .mli files which we can use to 
generate stuff like: 
  http://www.xen.org/files/XenCloud/ocamldoc/

I think we should zap this Makefile rule and keep our comments. 

> Then 'make allxen' prints:
> File "xb.ml", line 1, characters 0-1:
> Error: The files op.cmi and xb.cmi make inconsistent assumptions
>        over interface Op
>
> A 'touch xb/xb.mli && make allxen' works.
> 
> IMHO this is because of missing dependencies in the Makefile. Try to  
> add one additional operation in op.ml and type 'make'. You'll see a  
> similar error. It looks that dependency tracking is missing:
> Example: xb.ml uses op.ml but it is not rebuild when op.ml changes.

I'm sure you're right. We've been a bit lazy with our dependencies in this 
repo, falling back to 'make clean && make'. Things are better in xen-api.hg 
where 'omake' (like 'make' but with a bit more ocaml-awareness) is quite good 
at tracking dependencies itself.

Cheers,
Dave

_______________________________________________
xen-api mailing list
xen-api@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/mailman/listinfo/xen-api