[Xen-devel] Re: [PATCH] x86 boot: simplify reloc.c

[Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxx>]

Keir Fraser wrote:
> On 10/11/2009 03:34, "Xiao Guangrong" <xiaoguangrong@xxxxxxxxxxxxxx> wrote:
> 
>> This patch simplify reloc.c with:
>> 1): no need separate make
>>     reloc.c -> reloc.o -> reloc.lnk -> reloc.bin -> reloc.S,
>>     and static embed reloc.S into head.S
>> 2): reuse memcpy() in string lib
>> 3): remove assemble code in the head of reloc.c
>>
>> [ It is just a cleanup patch and not change the code's logic, and it work 
>> well
>> on x86.
>>   Not have x86_64 machine in my hand, thanks very much if someone can test it
>> on x86_64 ]
> 
> The patch misses the point of reloc.c, which is that it is supposed to run
> in 32-bit mode. All the stuff you stripped out is exactly what's needed to
> make it work with 64-bit Xen.
> 

Ah, sorry for this noise, I'll do some work on x86-64 about this patch.

Thanks,
Xiao

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel