Re: [Xen-devel] [PATCH 0/7][RFC] make xenguest save & restore functions reentrant

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 13/11/2009 23:43, "Vincent Hanquez" <vincent.hanquez@xxxxxxxxxxxxx>
wrote:

> The following patchset make suspend and restore code reentrant by having an
> explicit context to store current variables across all the suspend/restore
> code.
> 
> This work is necessary for beeing able to get rid of the fork of processes
> during save&restore, and provide a simpler interface for toolstack developers.

Rather than making the macros take extra arguments, can you make them refer
to ctx->foo instead (i.e., make it implciit the structure containing these
ex-globals is called ctx)? It avoids having to change every caller, and some
callers already have macros nested three deep and adding guest_width/max_mfn
all over the place does not help readability.

Also send also as attachments next time. I have problems applying these
patches from inline email for some reason; some chunks don't apply.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel