Re: [Xen-devel] [PATCH] Dont call msi_unmap_pirq() if did not enabled msi

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Mon, Nov 16, 2009 at 10:15:46AM -0500, Konrad Rzeszutek Wilk wrote:
> On Mon, Nov 16, 2009 at 08:00:30PM +0800, Joe Jin wrote:
> > Hi,
> > 
> > When device driver unload, it may call pci_disable_msi(), if msi did not 
> > enabled but do msi_unmap_pirq(), then later driver reload and without
> 
> Where does that happen? That looks to be a driver bug as well.
> 
> > msi, then will failed in request_irq() for irq_desc[irq]->chip valie is 
> > no_irq_chip. So when did not enable msi during driver initializing, then
> 
> Won't that mean it is unusable? As in, you can't allocate an IRQ
> to the device when the irq_desc[irq]->chip_value==no_irq_chip?

Duh! I think I answered myself here and the answer is yes, otherwise you
would not have hit this bug :-(

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel