[Xen-devel] [PATCH] tmem: fix regression from c/s 19886 "Remove page-scrub lists and async scrubbing"

[Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>]

Fix incorrect page_list macro choice from page-scrub
code cleanup.

Signed-off-by: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>

diff -r bec27eb6f72c xen/common/tmem_xen.c
--- a/xen/common/tmem_xen.c     Sat Nov 14 10:32:59 2009 +0000
+++ b/xen/common/tmem_xen.c     Mon Nov 16 11:09:17 2009 -0700
@@ -213,12 +213,13 @@ EXPORT void tmh_release_avail_pages_to_h
     spin_lock(&tmh_page_list_lock);
     while ( !page_list_empty(&tmh_page_list) )
     {
-        struct page_info *pg = page_list_first(&tmh_page_list);
+        struct page_info *pg = page_list_remove_head(&tmh_page_list);
         scrub_one_page(pg);
+        tmh_page_list_pages--;
         free_domheap_page(pg);
     }
+    ASSERT(tmh_page_list_pages == 0);
     INIT_PAGE_LIST_HEAD(&tmh_page_list);
-    tmh_page_list_pages = 0;
     spin_unlock(&tmh_page_list_lock);
 }

Attachment: tmem-scrub-regress.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel