|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] RE: [PATCH][1/2] pvops-dom0: Xen acpi processor logic cleanup
>Thanks, this looks like a big improvement. I have some comments about >the details though: > > * Split this into 3 patches: > o revert the old Xen-specific changes > o add the new common code (which may just be > is_processor_apic_enabled()) > o add the new Xen-specific code in a new file Thanks for the comments. I split the original patch into three patch as you suggested. However, after it is done, I notice the original patch has already been checked in. so I just attach the three patch for your information, in case you still need that. > * Make acpi_processor_driver a pointer to the preferred driver > structure which defaults to the normal driver, and have some Xen > code re-point it to the Xen one during Xen setup, rather than > having an explicit Xen test in the core ACPI code This approach will introduce another dependency between xen setup code and acpi processor driver module, and again cannot pass compiling when CONFIG_ACPI_PROCESSOR=m. so I would suggest to keep it as it is. How do you think? Best Regards Ke Attachment:
3_xen-acpi-new.patch Attachment:
1_xen-acpi-revert.patch Attachment:
2_xen-acpi-common.patch _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |