Re: [Xen-devel] [PATCH] Implement rdtscp emulation and rdtscp_aux "support"

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 26/11/2009 08:15, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> I realize that my comment really applies to your earlier patch introducing
> rdtsc emulation, but somehow that aspect slipped my attention back
> then: Linux has, as a security option, a mechanism to disable rdtsc for
> apps, but your emulation code doesn't honor the guest setting of
> CR4.TSD.

I'll fix this. While I'm at it, I think our PV emulation of MOV CR4,reg is
broken -- should just return v->arch.guest_context.ctrlreg[4], would you
agree? Otherwise guest's CR4.TSD isn't returned.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel