[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [Patch]: conflicting sysctl numbers


  • To: "Kamble, Nitin A" <nitin.a.kamble@xxxxxxxxx>
  • From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
  • Date: Tue, 01 Dec 2009 07:46:10 +0100
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
  • Delivery-date: Mon, 30 Nov 2009 22:46:37 -0800
  • Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:X-Enigmail-Version:Content-Type; b=EGa5wrBe3CvuH5sfrERFF+ssAnPGKizEgvU4QJ26dTowoNnOHnpCaP83 7Te9/Q9PD+LS+ihY197zUzJL6xYcYG7Y5lT/E5Zgaf/5iKfZ9MhBy+brR +S0p4OXxRb0HzN2QTbTctxtKiRhzpstand4fgQAxV2HNEc7VPhd7p689U e1I+P1NeJncZCcWCt3+7lLXVrVNiMiDmKrW4MqtgE8vdPKGsvQ61hzJUL OYvthE4dE6/fRSt7HixAWVEQQfDaP;
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Attached patch fixes the problem.

Kamble, Nitin A wrote:
> Keir,
> 
>  
> 
> I found there are two sysctls with conflicting same sysctl no in the
> code. This looks like a issue caused by merging code from different
> developers, and need fixing.
> 
> xen/include/public/sysctl.h
> 
> #define XEN_SYSCTL_cpu_hotplug       11
> 
> #define XEN_SYSCTL_lockprof_op       11
>  
> 
> Looks like this has come from changeset 20312:
> 
> Spinlock profiling (enable in build with lock_profile=y)


-- 
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technolgy Solutions               e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html
# HG changeset patch
# User juergen.gross@xxxxxxxxxxxxxx
# Date 1259649761 -3600
# Node ID b8915cc97db6189b1146e692c70cc1ea62baf776
# Parent  abc6183f486e66b5721dbf0313ee0d3460613a99

Signed-off-by: juergen.gross@xxxxxxxxxxxxxx

use free sysctl_op number

diff -r abc6183f486e -r b8915cc97db6 xen/include/public/sysctl.h
--- a/xen/include/public/sysctl.h       Mon Nov 30 10:58:23 2009 +0000
+++ b/xen/include/public/sysctl.h       Tue Dec 01 07:42:41 2009 +0100
@@ -454,7 +454,7 @@
 
 #define PG_OFFLINE_OWNER_SHIFT 16
 
-#define XEN_SYSCTL_lockprof_op       11
+#define XEN_SYSCTL_lockprof_op       15
 /* Sub-operations: */
 #define XEN_SYSCTL_LOCKPROF_reset 1   /* Reset all profile data to zero. */
 #define XEN_SYSCTL_LOCKPROF_query 2   /* Get lock profile information. */
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.