[Xen-devel] RE: XCP: Patch to XenAPI stack to allow domain resume, HAP control and a few other features.

[Dave Scott <Dave.Scott@xxxxxxxxxxxxx>]

Hi Roger,

Sorry for the delay reviewing this patch.

I'm fine with all the changes except this one:

> diff -r 3e8c0167940d -r 80df1bc7ce62 ocaml/xapi/xapi_event.ml
> --- a/ocaml/xapi/xapi_event.ml      Wed Nov 11 16:55:51 2009 +0000
> +++ b/ocaml/xapi/xapi_event.ml      Wed Nov 18 14:49:01 2009 -0500
> @@ -282,10 +282,10 @@ let heartbeat ~__context =
>        (fun () ->
>        (* We must hold the database lock since we are sending an update for a 
> real object
>           and we don't want to accidentally transmit an older snapshot. *)
> -     let pool = Helpers.get_pool ~__context in
> -     let pool_r = Db.Pool.get_record ~__context ~self:pool in
> -     let pool_xml = API.To.pool_t pool_r in
> -     event_add ~snapshot:pool_xml "pool" "mod" (Ref.string_of pool)
> +     let sm = List.hd (Db.SM.get_all ~__context) in
> +     let sm_r = Db.SM.get_record ~__context ~self:sm in
> +     let sm_xml = API.To.sM_t sm_r in
> +     event_add ~snapshot:sm_xml "SM" "mod" (Ref.string_of sm)
>        )
>    with e ->
>      error "Caught exception sending event heartbeat: %s" 
> (ExnHelper.string_of_exn e)

Could you explain why you want to change a Pool event into an SM one? 
Unfortunately I think some people are depending on receiving these regular Pool 
events to verify that the connection is still alive... It's a bit ugly but will 
have to do until we think of something better.

Anyway, if you resend a patch containing everything but this (with a 
signed-off-by: line and a nice commit comment) then I'll put it in the queue 
for pushing.

Cheers,
Dave

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel