[Xen-devel] Re: [PATCH] libxenlight: clone context to avoid GC corruption

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 3 Dec 2009, Vincent Hanquez wrote:
> On Wed, Dec 02, 2009 at 10:09:10PM +0000, Andres Lagar-Cavilla wrote:
> > Provide a function to clone a context. This is necessary
> > because simply copying the structs will eventually
> > corrup the GC: maxsize is updated in the cloned context
> > but not in the originating one, yet they have the same
> > array of referenced pointers alloc_ptrs.
> 
> I think this doesn't answer the question of why you need this function
> at all. I don't think you should clone the context nor share it.
> 
 
At the moment we need to clone the context in few places to open a new
xenstore connection and add temporary watches on xenstore nodes to
synchronously wait for events.

It is a simple solution to avoid conflicts when reading watches and I
think is OK as long as we don't have too many of these temporary watches
(we only have two places right now). 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel