Re: [Xen-devel] [PATCH] libxl: build fix

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Christoph Egger writes ("[Xen-devel] [PATCH] libxl: build fix"):
> Attached patch makes libxl build on NetBSD.

The patch is fine, although I don't generally approve of comments like
the one you've included:

+#include <signal.h> /* for SIGKILL */

I would just say:

+#include <signal.h>

and you can mention SIGKILL in the commit message.


There is an argument that all of these headers should be included in
one place by libxl_internal.h.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel